Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethdb/leveldb: support more than 7 levels in metrics #27904

Merged
merged 3 commits into from
Aug 11, 2023
Merged

ethdb/leveldb: support more than 7 levels in metrics #27904

merged 3 commits into from
Aug 11, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 11, 2023

fix #27902

@jsvisa
ethdb/leveldb: leveldb maybe has more than 7levels
66c9679 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
ethdb/leveldb: append the missing gauge
292799b 
Signed-off-by: jsvisa <delweng@gmail.com>
holiman
holiman reviewed Aug 11, 2023
View reviewed changes
ethdb/leveldb/leveldb.go Outdated Show resolved Hide resolved
@jsvisa
ethdb/leveldb: append in for-loop
38b282a 
Signed-off-by: jsvisa <delweng@gmail.com>
holiman
holiman approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl changed the title ethdb/leveldb: leveldb maybe has more than 7levels ethdb/leveldb: support more than 7 levels in metrics Aug 11, 2023
@fjl fjl merged commit 35f7f3d into ethereum:master Aug 11, 2023
1 check passed
fjl pushed a commit that referenced this pull request Aug 12, 2023
@jsvisa @fjl
ethdb/leveldb: support more than 7 levels in metrics (#27904)
770db14
@MelnikovAG
Copy link

fix #27902

@jsvisa jsvisa deleted the leveldb-more-than-7 branch August 21, 2023 13:27
@claudiughioc claudiughioc mentioned this pull request Sep 27, 2023
Closed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
ethdb/leveldb: support more than 7 levels in metrics (ethereum#27904)
4c8cdb4
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "ethdb/leveldb: support more than 7 levels in metrics (ethereu…
8d492d8 
…m#27904)"

This reverts commit 4c8cdb4.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "ethdb/leveldb: support more than 7 levels in metrics (ethereu…
aa722b8 
…m#27904)"

This reverts commit 4c8cdb4.
@weiihann weiihann mentioned this pull request Nov 20, 2023
Closed
@bgiegel bgiegel mentioned this pull request Jul 18, 2024
Merged
@intx4 intx4 mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 left review comments

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geth crashes on start-up
5 participants
@jsvisa @MelnikovAG @holiman @rjl493456442 @fjl